

So there’s a couple errors I can see in there: one which causes your issue here, and one that will cause another painful issue, unless you’re lucky.
malloc(strlen(buffer + 1));is not the same asmalloc(strlen(buffer) + 1);. Your allocation is actually one byte shorter than your input string. This means yourstrcpywill copy a byte past the allocated buffer. Only bad things can come out of that, and they may not be noticeable at first.- The issue you’re actually describing here requires maybe a bit better of an understanding of pointers.
mallocis giving you back an address - call it0x0001- and promises to have at least the available size you requested. You promise to at some pointfreethat address. That address is stored intoline.strchrreturns a different address - one later in the string, specifically. Your loop continuously advanceslineto that new address plus one. So, at the end, you’ve been given an address, 0x0001, and you’re trying to free some other address - e.g. 0x10de. That’s why you can’t free; you’re freeing something other than what you malloc’d. You need to hold onto the actual address returned by malloc in another variable, and free that address specifically.
For #1, I’d personally recommend taking a look at strdup instead of malloc + strcpy. It’s identical functionally, so I invite you to wholly understand all three functions and understand when/why they’re used, but when copying a string exactly, strdup is the way to go - and it removes the possibility of an errant + 1. As part of the understanding, understand that the result of strdup does still need to be given to free eventually.
As a general note, to provide maybe some clarity on “is it fine to not free strings” - strings don’t really exist in C. That is, there’s not some special thing that the system sees as a string. They’re by convention - a string is a blob of non-'\0' bytes that ends with '\0'. malloc and free do not know or care what you did with the bytes you received, and whenever you see a man page say that it does something with a string (copy, search, etc.), you can confidently substitute string with “blob of non-nul bytes ending with a nul byte”. “string” just sounds nicer, and by convention, that’s what we know a “C string” to be.


S&P500 lifetime inflation-adjusted return is 7-8%. meaning, if one put away 150K in the S&P500 at age 20 and worked for 40 years, putting away nothing else but gaining that inflation-adjusted 7-8 (conservatively call it 7), and then pulled out a measly 4%, allowing the remaining growth to account for inflation, they’d be pulling an inflation-adjusted income of >80K, ignoring any other income.
I’m not saying one shouldn’t put anything else away or strictly count on matching historical S&P return, but yes, putting away 150K at 20 could absolutely mean you don’t need to put anything away again.